From: wehmann
To: eli
Subject: Re: rmail spam filter
Date: Mon, 29 Sep 2003 13:10:09 -0500

Hi Eli,

Below are the results of running diff.  I didn't try with Emacs 21.3,
but I downloaded the 21.3 tar file and examined "rmail.el" and
"rmailout.el" & I see that my changes probably wouldn't have been necessary had
I been using Emacs 21.3 (I didn't check on "rmail-enable-multibyte").

-----------------------------------------------------------------

bash-2.05b$ diff rmail-spam-filter.el
/cygdrive/n/emacs/xemacs/rmail-spam-filter.el
414c414
< 		  (rmail-output-to-rmail-file rmail-spam-file 1 t)
---
> 		  (rmail-output-to-rmail-file rmail-spam-file 1)

bash-2.05b$ diff get-new-mail-for-spam-filter.el
/cygdrive/n/emacs/xemacs/get-new-mail-for-spam-filter.el
34c34
< 	(rmail-enable-multibyte (default-value 'enable-multibyte-characters))
---
> 	;;(rmail-enable-multibyte (default-value 'enable-multibyte-characters))
157,158c157
< 			    (when (rmail-expunge-confirmed)
<                               (rmail-only-expunge))
---
> 			    (rmail-only-expunge)
223a223

-----------------------------------------------------------------

Our Computing Division support group has developed a definite bias
towards supporting XEmacs--not Emacs, on our central cluster of Unix
machines.  But inconsistencies abound here.  The previous person who
was "sysadmin" for my Windows 2000 PC installed Emacs on it--not
XEmacs.  On a more local Unix cluster geographically near me, the
system manager provides Emacs in much better shape than XEmacs.

Thanks again,
Alan


-- 
Alan Wehmann
Fermilab
========================================================================
From: "Thomas D. Dean" <tomdean>
To: eli
Subject: Change to rmail-spam-filter.el for EMACS 20.7.1
Date: Fri, 26 Sep 2003 17:23:38 -0700 (PDT)

To make rmail-spam-filter.el on my FreeBSD system:

diff rmail-spam-filter.el~ rmail-spam-filter.el
414c414
<                 (rmail-output-to-rmail-file rmail-spam-file 1 t)
---
>                 (rmail-output-to-rmail-file rmail-spam-file 1) t


tomdean


========================================================================
From:  Bernd Kiefer
To: tomdean
cc: eli
Subject: Re: Change to rmail-spam-filter.el for EMACS 20.7.1
Date: Wed, 1 Oct 2003 13:42:28 +0200


Hi, i was on vacation the last weeks and i am just catching up with my
emails.

As to the first patch:

 > diff rmail-spam-filter.el~ rmail-spam-filter.el
 > 414c414
 > <                 (rmail-output-to-rmail-file rmail-spam-file 1 t)
 > ---
 > >                 (rmail-output-to-rmail-file rmail-spam-file 1) t

I added the second parameter, which only works with in version 21,
to avoid unread messages to be marked incorrectly as read. Don't you
get this problem in version 20.7? By the way, you better delete the 
"t" because the way you did it, is has no effect and will confuse 
people who look at the code.

Change your definition of rmail-expunge-confirmed as follows:

(defun rmail-expunge-confirmed ()
  t)

and you should get the desired result.

========================================================================
From: "Thomas D. Dean" <tomdean>
To: eli
CC: kiefer
Subject: Re: Change to rmail-spam-filter.el for EMACS 20.7.1
Date: Fri, 26 Sep 2003 17:52:00 -0700 (PDT)

My last email was incomplete.  I defined

(defun rmail-expunge-confirmed ()
  asdfasdf-junk )

and get a message 'symbol's value is void'  But, I get the results I want.

tomdean

========================================================================
From: "Thomas D. Dean" <tomdean>
To: eli
CC: kiefer
Subject: Re: Change to rmail-spam-filter.el for EMACS 20.7.1
Date: Fri, 26 Sep 2003 18:11:32 -0700 (PDT)

If I change

diff get-new-mail-for-spam-filter.el get-new-mail-for-spam-filter.el~
157,158d156
<                           (rmail-select-summary
<                            (rmail-update-summary))

I get the behavior I want, with the exception of the message about
rmail-expunge-confirmed.

tomdean
========================================================================
From: Shimon Edelman <se37>
Sender: Shimon Edelman <edelman>
To: eli
Subject: rmail-spam-filter - a bug?
Date: Tue, 2 Sep 2003 11:38:55 -0400

Dear Eli,

I believe that the file  get-new-mail-for-spam-filter.el  that is
linked from 

http://www.deas.harvard.edu/climate/eli/Downloads/rmail-spam-filter/

has a bug: the statement

    (setq rmail-current-message (1- rmail-current-message))

seems to be unnecessary (before I commented it out, the filter
regularly swallowed non-spam messages). FYI, I am using emacs 21.3.

Thanks for writing rmail-spam-filter!

-Shimon

p.s. If you're no longer involved with this project, I apologize.

Shimon Edelman
========================================================================
========================================================================
========================================================================